Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Upgrade to SvelteKit 1.0.0-next.211 and related fixes #58

Merged

Conversation

lulzneko
Copy link
Contributor

@lulzneko lulzneko commented Jan 1, 2022

Upgrade the SvelteKit dependency to the latest version, SvelteKit 1.0.0-next.211.

There will also be fixes associated with it.
Mainly related to the following SvelteKit PRs

@Kelvijn
Copy link

Kelvijn commented Jan 5, 2022

Hope this gets merged quickly! Great job @lulzneko

@ByronCobb
Copy link

@Kelvijn thank you for the fork. Hopefully @Dan6erbond can merge this asap, as the bug makes this repo unusable.

@Kelvijn
Copy link

Kelvijn commented Jan 7, 2022

@Kelvijn thank you for the fork. Hopefully @Dan6erbond can merge this asap, as the bug makes this repo unusable.

@ByronCobb Credits to @lulzneko!

Did you get the fork working on your machine? I didn't when installing the package from my github URL, the node module didn't contain any index file only the package.json, tips? 😀

@timwedde
Copy link

timwedde commented Jan 7, 2022

I, too, am blocked by this, would be nice if this could get merged.

@ByronCobb
Copy link

@Kelvijn I've not yet tried it, but this stackoverflow answer seems to be relevant.
https://stackoverflow.com/a/57503862

I think in short it recommends adding an empty .npmignore to the fork.

@Dan6erbond
Copy link
Owner

Sorry everyone! I missed this breaking change, but good catch @lulzneko. Will merge this ASAP once I get the linting errors to resolve, and I'm glad to see the Svelte team has simplified the way URLs work. Should also improve error tolerance from issues such as #59.

@Dan6erbond Dan6erbond merged commit 9a5dbe2 into Dan6erbond:main Jan 12, 2022
@lulzneko lulzneko deleted the dependencies/sveltekit-1.0.0-next.211 branch January 13, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants