Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timetable week problem #218

Merged
merged 3 commits into from
Mar 5, 2023
Merged

fix: timetable week problem #218

merged 3 commits into from
Mar 5, 2023

Conversation

ivanfei-1
Copy link
Member

Move the courses on Sundays a week forward to match the school schedule.
Close #217.

@w568w
Copy link
Member

w568w commented Mar 4, 2023

Could there be a chance that a Course is on both Sunday and Monday?

Say, course A is on Week 1's Sun. & Mon. (i.e. 2/19 & 2/20) in this term. Under your any() assertion, it will be add to both Week 0 and 1 (i.e. 2/13, 2/19, 2/20 and 2/26).

Consider moving assessments like course.times!.any((element) => element.weekDay != 6)) into the inner for loop.

Copy link
Member

@w568w w568w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

Copy link
Member Author

@ivanfei-1 ivanfei-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@ivanfei-1 ivanfei-1 requested a review from w568w March 4, 2023 05:07
@w568w w568w merged commit c09112e into main Mar 5, 2023
@w568w w568w deleted the time-table-fix branch March 5, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong timetable display
2 participants