adjust the logic of adding course manually

[AInfinity-LilacDream]

adjust the logic of adding course manually so that courses on Sunday will be displayed correctly

[w568w]

A few thoughts:

• Your commit message format does not conform to the required guidelines¹². Please reword it to something like fix: ... or change: ...³;
• Before modifying (especially reverting) someone else's changes, ask the person who made that change first: (e.g., in this issue) “Why did you treat the weekend differently? Was there some consideration for fixing other bugs? Is there a risk that my roll-back will cause other cascading problems?” Avoid letting a narrow focus on fixing a specific issue prevent you from seeing other, larger problems, which could make things worse⁴!
• You can link a PR to an issue. Check out GitHub documentation.

When you feel that you are done, reply to this PR to notify me.

Footnotes

1. https://github.com/DanXi-Dev/DanXi/commit/3262b64b61b8670c8879663df73ea1a140804ff5#comments ↩

2. https://ruby-china.org/topics/15737 ↩

3. I have also given some instructions about the best practice in Feishu work group "旦夕 App". Please read the pinned messages there first. ↩

4. With Intellij IDEs, you can list who has ever changed the lines with View Selection History. ↩

[w568w]

For the 2nd point, it turns out that @ivanfei-1 added those lines in b253ce9 to fix #217. Please check that first.

[w568w]

As above.

[AInfinity-LilacDream]

Too busy last week，just working on it，at most four days required.

…

---Original--- From: ***@***.***> Date: Tue, Oct 22, 2024 11:43 AM To: ***@***.***>; Cc: ***@***.******@***.***>; Subject: Re: [DanXi-Dev/DanXi] adjust the logic of adding course manually (PR#427) @w568w requested changes on this pull request. As above. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>