ext/standard: Transform tentative return types into proper types for …

…Directory class This class is now final
DanielEScherzer · Oct 27, 2024 · e8a1781 · e8a1781
1 parent 0640fba
commit e8a1781
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/ext/standard/dir.stub.php b/ext/standard/dir.stub.php
@@ -99,19 +99,16 @@ final class Directory
     public readonly mixed $handle;
 
     /**
-     * @tentative-return-type
      * @implementation-alias closedir
      */
     public function close(): void {}
 
     /**
-     * @tentative-return-type
      * @implementation-alias rewinddir
      */
     public function rewind(): void {}
 
     /**
-     * @tentative-return-type
      * @implementation-alias readdir
      */
     public function read(): string|false {}

diff --git a/ext/standard/dir_arginfo.h b/ext/standard/dir_arginfo.h
diff --git a/ext/standard/tests/directory/DirectoryClass_reflection_structure.phpt b/ext/standard/tests/directory/DirectoryClass_reflection_structure.phpt
@@ -12,9 +12,9 @@ $rc = new ReflectionClass("Directory");
 echo $rc;
 
 ?>
---EXPECTF--
+--EXPECT--
 Structure of Directory class:
-Class [ <internal%s> final class Directory ] {
+Class [ <internal:standard> final class Directory ] {
 
   - Constants [0] {
   }
@@ -35,21 +35,21 @@ Class [ <internal%s> final class Directory ] {
 
       - Parameters [0] {
       }
-      - Tentative return [ void ]
+      - Return [ void ]
     }
 
     Method [ <internal:standard> public method rewind ] {
 
       - Parameters [0] {
       }
-      - Tentative return [ void ]
+      - Return [ void ]
     }
 
     Method [ <internal:standard> public method read ] {
 
       - Parameters [0] {
       }
-      - Tentative return [ string|false ]
+      - Return [ string|false ]
     }
   }
 }