Make core available as standalone consumable modules #42
Conversation
| @@ -196,6 +196,9 @@ const CSVGood = function (file, onStep, onError, onComplete) { | |||
|
|
|||
| fileReader.onload = (evt) => { | |||
| // Take result | |||
| if (!evt.target) { | |||
| throw new Error("Expected event to have a target") | |||
| } | |||
There was a problem hiding this comment.
I added all these types of checks to satisfy the type-checker errors thrown by the TS compiler where technically APIs can return null/undefined.
| } | ||
| }); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Basically a collection of all browser based code I collected from convert.js
|
Hi, Sorry for the late reply. Have been a bit busy. Although I am very glad you put so much effort into this, I think these changes are too big for me personally. Especially since we are talking about a small feature. If I were to create an electron build of the system, I think I would be okay with this. However I believe the system is easier and just as safe to use in the browser browser. You are of course free to fork this project and change all the code as needed. The only changes that I can foresee (except bugfixes and added support for banks which are easily integrated into your fork) are a merge with the ABN AMRO version of YNABGoingDutch #25 and an integration into the YNAB api #26 . However these features are not guaranteed to be implemented ever. I can always link to your repo in the readme.md if you'd like. Thanks again for the effort you put into this! |
|
Makes total sense and no worries, I need this so there’s nothing lost here.
I’m tracking the API one, but also don’t foresee it being a real problem to merge back in if it ever gets done.
Yeah that would be nice, I’m sure there will be some other dev at some point that wants this 👍
Thank you for the original work! |
Opening this early and unpolished to illustrate what it could look like and to discuss requirements. I tried to stay as close as possible to your original intent/style, but can totally understand if this is too much of a change for you. (I can always just use this forked code myself, as I don’t imagine there will be much changes in the future.)
Changes:
notiewith original ES6 version.Considerations:
.mjsto signal they are ES6 modules?FileAPI does not exist natively in NodeJS (nor does any polyfill package seem to provide all the relied upon APIs).Closes #41