Skip to content

Commit

Permalink
Make break-before propagation work beyond one level up.
Browse files Browse the repository at this point in the history
Need to propagate the break-before value of the layout result, just
like we already do for break-after a few lines further down.

Bug: 1293287
Change-Id: I690719c332086b89b073f522f250b0f263d0cf41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430143
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#966399}
  • Loading branch information
mstensho authored and DanielRyanSmith committed Feb 28, 2022
1 parent f96b476 commit 6df3956
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 0 deletions.
16 changes: 16 additions & 0 deletions css/css-break/break-between-avoid-009.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://www.w3.org/TR/css-break-3/#break-propagation">
<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div style="width:100px; height:100px; background:red;">
<div style="columns:2; column-fill:auto; column-gap:0; height:250px;">
<div style="height:100px; background:green;"></div>
<div style="height:100px; background:green;"></div>
<div style="break-inside:avoid;">
<div>
<div style="break-before:avoid; height:100px;"></div>
</div>
</div>
</div>
</div>
15 changes: 15 additions & 0 deletions css/css-break/break-between-force-000.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://www.w3.org/TR/css-break-3/#break-propagation">
<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div style="width:100px; height:100px; background:red;">
<div style="columns:2; column-fill:auto; column-gap:0; height:250px;">
<div style="height:100px; background:green;"></div>
<div style="break-inside:avoid;">
<div>
<div style="break-before:column; height:100px; background:green;"></div>
</div>
</div>
</div>
</div>

0 comments on commit 6df3956

Please sign in to comment.