Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fj 2024 lesson 14 #12

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Fj 2024 lesson 14 #12

wants to merge 28 commits into from

Conversation

Daniil-Vl
Copy link
Owner

@Daniil-Vl Daniil-Vl commented Nov 14, 2024

Настроил workflow для основного сервиса (kudago) и для сервиса для конвертации валют (из 8 дз вроде).
В процессе проект собирается, тестируется, упаковывается в docker image и загружается в github container registry. Также отдельно запускается статическая проверка кода с помощью checkstyle.

В начале так много коммитов, т.к. я пытался решить проблему с jacoco. А проблема заключалась в том, что не выводилось сообщение с процентом покрытия кода тестами. В итоге плотно пообщавшись с Chat-GPT и просмотрев половину интернета и я все-таки нашел решение в одном из issue jacoco-report: Madrapps/jacoco-report#70.

В целом можно изменения в *.java файлах не смотреть, там я просто чинил стили, чтобы проходила проверка. Зато так видно, что в некоторых коммитах сборка не проходила из-за того, что стиль кода на соответсвовал checkstyle.xml.

Copy link

Test comment from GitHub Actions

Copy link

Test comment from GitHub Actions

Copy link

Code Coverage

Overall Project 85.42% 🍏

There is no coverage information present for the Files changed

Copy link

Test comment from GitHub Actions

Copy link

Code Coverage

Overall Project 85.42% 🍏

There is no coverage information present for the Files changed

Copy link

Code Coverage

Overall Project 84.14% 🍏

There is no coverage information present for the Files changed

Copy link

Code Coverage

Overall Project 84.14% 🍏

There is no coverage information present for the Files changed

Copy link

Code Coverage

Overall Project 84.14% 🍏

There is no coverage information present for the Files changed

Copy link

Code Coverage

Overall Project 84.14% 🍏

There is no coverage information present for the Files changed

Copy link

Code Coverage

Overall Project 85.42% 🍏

There is no coverage information present for the Files changed

Copy link

Code Coverage

Overall Project 85.42% 🍏

There is no coverage information present for the Files changed

Copy link

Code Coverage

Overall Project 85.42% 🍏

There is no coverage information present for the Files changed

Copy link

Code Coverage

Overall Project 84.14% 🍏
File Coverage
CategoryController.java 100% 🍏
CityController.java 100% 🍏

Copy link

Code Coverage

Overall Project 84.14% 🍏
File Coverage
CategoryController.java 100% 🍏
CityController.java 100% 🍏

Copy link

Code Coverage

Overall Project 85.42% 🍏

There is no coverage information present for the Files changed

@SoldatovAlexandr
Copy link

огонь

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants