Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tests #123

Merged
merged 8 commits into from
Dec 25, 2024
Merged

Add new tests #123

merged 8 commits into from
Dec 25, 2024

Conversation

Dankoy
Copy link
Owner

@Dankoy Dankoy commented Dec 11, 2024

Description

New test cases for State Service

This MR introduces new test cases to ensure the correct functionality of the StateServiceSqlite. The tests cover scenarios such as checking states returned by service, filtering states with empty final state list, and retrieving vocabulary objects.

Changes

  • Added two new test methods: testCheckState and testFilterState_EmptyFinalStateList_ReturnsAllVocabularies
  • Created a mock StateDao to facilitate testing
  • Updated the StateServiceSqlite to use the mocked StateDao

Notes

Please review the updated test cases and ensure they cover all necessary scenarios. If any additional tests are required, please let me know.

Updated test cases for Google Translator Web Client

This MR updates the test cases for the GoogleTranslatorWebClient to ensure its correct functionality. The tests cover various scenarios such as translating text, handling API responses, and error handling.

Changes

  • Added new test methods to cover additional scenarios
  • Updated existing test methods to reflect changes in the GoogleTranslatorWebClient
  • Improved code organization and readability

Notes

Please review the updated test cases and ensure they cover all necessary scenarios. If any additional tests are required, please let me know.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Dankoy Dankoy added the documentation Improvements or additions to documentation label Dec 11, 2024
@Dankoy Dankoy self-assigned this Dec 11, 2024
@Dankoy Dankoy merged commit 894a613 into main Dec 25, 2024
8 checks passed
@Dankoy Dankoy deleted the add-new-tests branch December 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant