Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build #816

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Fix Windows build #816

merged 1 commit into from
Feb 8, 2024

Conversation

sgrigory
Copy link
Contributor

@sgrigory sgrigory commented Feb 6, 2024

Fix build error reported in #814

I don't have a way to test this on Windows, but @bottler pointed out that long keyword is the likely problem. Is there a way to run Windows CI on this PR? @tridao

@sgrigory sgrigory marked this pull request as ready for review February 6, 2024 13:43
@shaltielshmid
Copy link

shaltielshmid commented Feb 6, 2024

I got it compiling on windows by changing to this (unrelated to your PR):

image

@bottler
Copy link
Contributor

bottler commented Feb 7, 2024

@shaltielshmid I think that your version would also be a valid fix, equally as good as this one.

@bdashore3
Copy link

@sgrigory I successfully built FA2 on windows using this PR. The Github Actions log is located here and the release is here

Thanks for the PR!

@tridao tridao merged commit 4687936 into Dao-AILab:main Feb 8, 2024
@tridao
Copy link
Contributor

tridao commented Feb 8, 2024

Thanks @sgrigory and @bottler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants