Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Firebird tests (Issue178_Firebird) #1917

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Re-enable Firebird tests (Issue178_Firebird) #1917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d8113e
Re-enable Firebird tests (Issue178_Firebird)
0xced Jun 13, 2023
225c3a2
Run Firebird in a docker container for the Firebird tests on AppVeyor
0xced Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ init:
- git config --global core.autocrlf input
- SET PATH=%POSTGRES_PATH%\bin;%MYSQL_PATH%\bin;%PATH%
- net start MSSQL$SQL2019
- docker run -d -p 3050:3050 --name Dapper.Tests.Firebird -e FIREBIRD_DATABASE=database -e ISC_PASSWORD=masterkey jacobalberty/firebird

nuget:
disable_publish_on_pr: true
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/Dapper.Tests.Performance/Dapper.Tests.Performance.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<PackageReference Include="DevExpress.Xpo" Version="20.2.3" />
<!--<PackageReference Include="BLToolkit" Version="4.3.6" />-->
<PackageReference Include="EntityFramework" Version="6.4.4" />
<PackageReference Include="FirebirdSql.Data.FirebirdClient" Version="7.5.0" />
<PackageReference Include="FirebirdSql.Data.FirebirdClient" Version="9.1.1" />
<PackageReference Include="linq2db.SqlServer" Version="3.1.6" />
<PackageReference Include="MySqlConnector" Version="1.1.0" />
<PackageReference Include="NHibernate" Version="5.3.5" />
Expand Down
2 changes: 1 addition & 1 deletion tests/Dapper.Tests/Dapper.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<ItemGroup>
<ProjectReference Include="../../Dapper.ProviderTools/Dapper.ProviderTools.csproj" />
<ProjectReference Include="../../Dapper.SqlBuilder/Dapper.SqlBuilder.csproj" />
<PackageReference Include="FirebirdSql.Data.FirebirdClient" Version="7.5.0" />
<PackageReference Include="FirebirdSql.Data.FirebirdClient" Version="9.1.1" />
<PackageReference Include="Microsoft.Data.SqlClient" Version="2.0.1" />
<PackageReference Include="Microsoft.Data.Sqlite" Version="5.0.0" />
<PackageReference Include="MySqlConnector" Version="1.1.0" />
Expand Down
2 changes: 1 addition & 1 deletion tests/Dapper.Tests/Providers/FirebirdTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class FirebirdTests : TestBase<FirebirdProvider>
{
private FbConnection GetOpenFirebirdConnection() => (FbConnection)Provider.GetOpenConnection();

[Fact(Skip = "Bug in Firebird; a PR to fix it has been submitted")]
[Fact]
public void Issue178_Firebird()
{
using (var connection = GetOpenFirebirdConnection())
Expand Down