Fix MySQL tests #774
Merged
Fix MySQL tests #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids creating a SQLConnection simply to Dispose it.
'connection' is a protected variable in the TestBase class that is a SQL Server connection, not a MySQL connection.
As per issue DapperLib#295, setting "AllowZeroDateTime=True" in the connection string causes an InvalidCastException in SqlMapper.
|
Well, damn. I wish you made this 3 days ago before I started the |
|
Well, if you had tweeted this three days ago, I might have started earlier 😜: https://twitter.com/Nick_Craver/status/862862874619805696 I author MySqlConnector so your tweet had got me thinking I should start support for But first I had to see if Dapper's MySQL tests could even run against the current version of my library, which is when the yak shaving began... |
|
=P fair enough, thanks for all the work and testing here, it's much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MySQLTests were being run against
TestBase.connection, which is aSQLConnection, not the local variableconn, which is theMySqlConnection.Once this was fixed, two tests started failing because #295 (
InvalidCastExceptionis thrown whenAllowZeroDateTime=Trueis present in the MySQL connection string) is still open.Finally, I added a minor optimisation to not lazily-create
TestBase.connectioninTestBase.Dispose; this is primarily useful for the MySQLTests that don't ever need to open aSQLConnectionto run.