Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing in arxiv format (and the build workflow) #45

Merged
merged 14 commits into from
Apr 15, 2024

Conversation

misharash
Copy link
Contributor

@misharash misharash commented Apr 5, 2024

These changes should fix #34:

  • replace the tilde ~ with space only if not preceded by the backslash \ using a regular expression;
  • replace the LaTeX space preceded by the backslash with a usual space.

@misharash
Copy link
Contributor Author

misharash commented Apr 9, 2024

The build checks seem to have failed due to a deprecated Ubuntu version, tried to fix that in a new commit (and also increased the Python 3 version).

@misharash
Copy link
Contributor Author

Apparently Python 2.7 is no longer supported in GitHub Actions either. Tried to fix the build by removing it and adding a few more Python 3 versions.

@kadrlica
Copy link
Member

kadrlica commented Apr 9, 2024

Starting at Python 3.8 is probably fine. Thanks for these changes btw!

@misharash
Copy link
Contributor Author

Sorry, I am rather new to the workflows. I enabled them in my fork, and will try to make sure it works there first.

@misharash
Copy link
Contributor Author

misharash commented Apr 9, 2024

Finally, the package is built successfully in my fork. (Still true with the next three commits.)

@misharash misharash changed the title Fix spacing in arxiv format Fix spacing in arxiv format (and the build workflow) Apr 9, 2024
@kadrlica kadrlica self-requested a review April 14, 2024 20:47
@kadrlica
Copy link
Member

Sorry that this took so long. I also didn't realize that I'd need to approve/launch each workflow for a contributor who was outside the hosting organization. Thanks for all the work debugging the workflow.

I've approved your PR, so you should be able to go ahead an merge (otherwise I can do it).

@misharash
Copy link
Contributor Author

misharash commented Apr 15, 2024

GitHub says I need write access to this repository to merge PRs, which I don't have.

It also appeared to me that the added replacement of \ might have an issue similar to the (resolved) one with tilde: \\ -> \ . On the other hand, it is not clear to me what the correct behavior should be in this case. Moreover, it does not seem very relevant to the names of authors.

@kadrlica kadrlica merged commit b611c89 into DarkEnergySurvey:master Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacing in arxiv format
2 participants