Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added movement interval in mouse_jiggler USB & BLE #303

Merged
merged 8 commits into from
Feb 2, 2023
Merged

Added movement interval in mouse_jiggler USB & BLE #303

merged 8 commits into from
Feb 2, 2023

Conversation

DocKuro
Copy link
Contributor

@DocKuro DocKuro commented Jan 26, 2023 •
edited by xMasterX
Loading

What's new

  • Added a selection for interval between movements in mouse_jiggler USB & BLE

Verification

  • The app will show a new line with selection for interval
  • the time can be changed using left/right buttons
  • the movements of the mouse will have different timings respecting the interval selected
  • the interval cannot be changed while the jiggling is running

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@DocKuro DocKuro requested a review from xMasterX as a code owner January 26, 2023 14:38
xMasterX
xMasterX approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made changes to your PR, you shouldn't use string_t use FuriString* instead as it now exists in API and doesn't require extra imports

@xMasterX xMasterX merged commit a0d5aa0 into DarkFlippers:dev Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xMasterX xMasterX xMasterX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DocKuro @xMasterX