Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subghz_remote_app #477

Merged
merged 5 commits into from
May 19, 2023
Merged

subghz_remote_app #477

merged 5 commits into from
May 19, 2023

Conversation

gid9798
Copy link
Collaborator

@gid9798 gid9798 commented May 18, 2023 •
edited by xMasterX
Loading

What's new

  • Rewritten to scene_manager
  • the original display and file format have been preserved
  • the size has decreased slightly

Verification

  • [ Describe how to verify changes ]

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gid9798 gid9798 requested a review from xMasterX as a code owner May 18, 2023 10:53
@RogueMaster
Copy link
Contributor

This is amazing! Could your next revision support holding the key for a different sub file? Can you make this work with IR too?

xMasterX
xMasterX approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xMasterX xMasterX merged commit de5afa1 into DarkFlippers:dev May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xMasterX xMasterX xMasterX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gid9798 @RogueMaster @xMasterX