Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlipFrid - uprade #54

Merged
merged 2 commits into from
Sep 3, 2022
Merged

FlipFrid - uprade #54

merged 2 commits into from
Sep 3, 2022

Conversation

Ganapati
Copy link

@Ganapati Ganapati commented Sep 1, 2022

What's new

  • Removed bad crc attack
  • Add fuzzing from existing dump
  • Changed UI

S2ciOnur
S2ciOnur approved these changes Sep 2, 2022
View reviewed changes
Copy link

@S2ciOnur S2ciOnur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azaitsev
Copy link
Contributor

azaitsev commented Sep 2, 2022

Why did you remove bad crc attack?

@xMasterX xMasterX merged commit f99c1a8 into DarkFlippers:dev Sep 3, 2022
@quantum-x
Copy link
Contributor

Hi @xMasterX -
Any chance to remove the hardcoded minimum "time_between_cards" ?
On certain readers, 0 delay causes overflows which opens the lock.
When the delay is forced to a minimum of 5s, this behaviour no longer works.

@Commmaned
Copy link

Instructions unclear now locked in Area 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S2ciOnur S2ciOnur S2ciOnur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ganapati @azaitsev @quantum-x @Commmaned @S2ciOnur @xMasterX