Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hid app merge fix #753

Merged
merged 4 commits into from
May 19, 2024
Merged

Hid app merge fix #753

merged 4 commits into from
May 19, 2024

Conversation

Willy-JL
Copy link
Contributor

@Willy-JL Willy-JL commented May 18, 2024 •
edited by xMasterX
Loading

What's new

  • Mostly just merging recent refactors from OFW of start scene and formatting to improve maintainability
  • Also new UI for Mouse Clicker from OFW was not merged, now it shows selected speed before starting

Verification

  • Opening and closing app, start screen works as intended
  • Mouse Clicker shows speed even before starting the clicker

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@Willy-JL Willy-JL requested a review from xMasterX as a code owner May 18, 2024 07:36
xMasterX
xMasterX approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we both missed one issue that is caused by my last changes in the app, ill merge that and push fix in next commit in dev branch
Thanks

@xMasterX xMasterX merged commit e4ed15b into DarkFlippers:dev May 19, 2024
@Willy-JL Willy-JL deleted the hid-app-merge-fix branch May 19, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xMasterX xMasterX xMasterX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Willy-JL @xMasterX