Remove Json type as unsupported (#448)

DarkWanderer · Mar 18, 2024 · c2af127 · c2af127
1 parent 61ff284
commit c2af127
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 44 deletions.
diff --git a/ClickHouse.Client.Tests/BulkCopyTests.cs b/ClickHouse.Client.Tests/BulkCopyTests.cs
@@ -85,6 +85,7 @@ public async Task ShouldExecuteMultipleBulkInsertions()
                     BatchSize = 100
                 };
 
+                await bulkCopy.InitAsync();
                 await bulkCopy.WriteToServerAsync(Enumerable.Repeat(new[] { (object)0 }, 1));
                 i++;
             }
@@ -187,7 +188,6 @@ public async Task ShouldExecuteBulkInsertWithComplexColumnName(string columnName
     }
 
     [Test]
-    [RequiredFeature(Feature.InlineQuery)]
     public async Task ShouldInsertIntoTableWithLotsOfColumns()
     {
         var tableName = "test.bulk_long_columns";

diff --git a/ClickHouse.Client.Tests/TestUtilities.cs b/ClickHouse.Client.Tests/TestUtilities.cs
@@ -214,11 +214,6 @@ public static IEnumerable<DataTypeSample> GetDataTypeSamples()
             Tuple.Create(.3, .4)
         });
 
-        if (SupportedFeatures.HasFlag(Feature.Json))
-        {
-            //yield return new DataTypeSample("Json", typeof(string), "'{\"a\": \"b\", \"c\": 3}'", "{\"a\": \"b\", \"c\": 3}");
-        }
-
         if (SupportedFeatures.HasFlag(Feature.Variant))
         {
             yield return new DataTypeSample("Variant(UInt64, String, Array(UInt64))", typeof(string), "'Hello, World!'::Variant(UInt64, String, Array(UInt64))", "Hello, World!");

diff --git a/ClickHouse.Client/ADO/Feature.cs b/ClickHouse.Client/ADO/Feature.cs
@@ -8,10 +8,6 @@ public enum Feature
 {
     None = 0, // Special value
 
-    [Obsolete]
-    [SinceVersion("20.5")]
-    InlineQuery = 2,
-
     [Obsolete]
     [SinceVersion("20.1")]
     DateTime64 = 4,
@@ -46,10 +42,6 @@ public enum Feature
     [SinceVersion("22.6")]
     Stats = 2048,
 
-    [Obsolete]
-    [SinceVersion("22.6")]
-    Json = 4096,
-
     [SinceVersion("22.8")]
     AsyncInsert = 8192,
 

diff --git a/ClickHouse.Client/Formats/HttpParameterFormatter.cs b/ClickHouse.Client/Formats/HttpParameterFormatter.cs
@@ -54,7 +54,6 @@ internal static string Format(ClickHouseType type, object value, bool quote)
             case IPv4Type ip4:
             case IPv6Type ip6:
             case UuidType uuidType:
-            case JsonType jsonType:
                 return quote ? value.ToString().Escape().QuoteSingle() : value.ToString().Escape();
 
             case LowCardinalityType lt:

diff --git a/ClickHouse.Client/Types/JsonType.cs b/ClickHouse.Client/Types/JsonType.cs
diff --git a/ClickHouse.Client/Types/TypeConverter.cs b/ClickHouse.Client/Types/TypeConverter.cs
@@ -167,7 +167,6 @@ static TypeConverter()
         RegisterPlainType<MultiPolygonType>();
 
         // JSON/Object
-        RegisterPlainType<JsonType>();
         RegisterParameterizedType<ObjectType>();
 
         // Mapping fixups