More tests for decimal type inference (#454)

DarkWanderer · Mar 20, 2024 · f609d8f · f609d8f
1 parent 0306072
commit f609d8f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/ClickHouse.Client.Tests/ORM/DapperTests.cs b/ClickHouse.Client.Tests/ORM/DapperTests.cs
@@ -177,12 +177,14 @@ public async Task ShouldExecuteSelectReturningDecimal()
     }
 
     [Test]
-    public async Task ShouldInsertParameterizedFloat64Array()
+    [TestCase(100)]
+    [TestCase(1000000000)]
+    [TestCase(123.456)]
+    [TestCase(0.0001)]
+    public async Task ShouldWriteDecimalWithTypeInference(decimal expected)
     {
-        const decimal expected = 123.456m;
-
         await connection.ExecuteStatementAsync("TRUNCATE TABLE IF EXISTS test.dapper_decimal");
-        await connection.ExecuteStatementAsync("CREATE TABLE IF NOT EXISTS test.dapper_decimal (balance Decimal128(4)) ENGINE Memory");
+        await connection.ExecuteStatementAsync("CREATE TABLE IF NOT EXISTS test.dapper_decimal (balance Decimal64(4)) ENGINE Memory");
 
 
         var sql = @"INSERT INTO test.dapper_decimal (balance) VALUES (@balance)";

diff --git a/ClickHouse.Client/ADO/Parameters/ClickHouseDbParameter.cs b/ClickHouse.Client/ADO/Parameters/ClickHouseDbParameter.cs
@@ -41,7 +41,7 @@ public string QueryForm
             {
                 var parts = decimal.GetBits(d);
                 int scale = (parts[3] >> 16) & 0x7F;
-                return $"{{{ParameterName}:Decimal(22,{scale})}}";
+                return $"{{{ParameterName}:Decimal128({scale})}}";
             }
 
             var chType = TypeConverter.ToClickHouseType(Value?.GetType() ?? typeof(DBNull)).ToString();