Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetSByte missing from DataReader #150

Closed
MaceWindu opened this issue Jul 18, 2022 · 1 comment
Closed

GetSByte missing from DataReader #150

MaceWindu opened this issue Jul 18, 2022 · 1 comment

Comments

@MaceWindu
Copy link

ClickHouseDataReader has read methods for all integers except sbyte. sbyte read still works with (sbyte)GetValue(ordinal), but for consistency it makes sense to add it.
@MaceWindu
Copy link
Author

BTW, having typed method also helps to get rid of unnecessary boxing, but current ClickHouseDataReader Get* methods implementation uses GetValue internally

@MaceWindu MaceWindu mentioned this issue Jul 18, 2022
Closed
DarkWanderer added a commit that referenced this issue Aug 6, 2022
@DarkWanderer
Adding 2 more custom DataReader methods. Closes #150 #151
88cbc0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MaceWindu