Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixed content when using a load balancer #127

Merged
merged 7 commits into from
May 9, 2023
Merged

Fix mixed content when using a load balancer #127

merged 7 commits into from
May 9, 2023

Conversation

ADReece
Copy link
Contributor

@ADReece ADReece commented May 4, 2023

Fixes: #126

ADReece added 3 commits May 4, 2023 16:25
@ADReece
Changed src/helpers.php
a4f2c91
@ADReece
Update swagger-lume.php config
b9be798 
added force_https config key.
@ADReece
Updated swagger-lume.php config
faa9161 
Updated config file to conform to styling.
DarkaOnLine
DarkaOnLine reviewed May 9, 2023
View reviewed changes
Copy link
Owner

@DarkaOnLine DarkaOnLine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add test and check if falg is sett that we serve assets with https?

config/swagger-lume.php Outdated Show resolved Hide resolved
src/helpers.php Outdated Show resolved Hide resolved
@ADReece
Copy link
Contributor Author

ADReece commented May 9, 2023

Could we also add test and check if falg is sett that we serve assets with https?

Hi @DarkaOnLine I've added PhpUnit tests for the default, a true and a false value on the requested SWAGGER_LUME_FORCE_HTTPS flag. Hopefully everything looks up to scratch now.

@coveralls
Copy link

Coverage Status

Coverage: 78.325% (+1.5%) from 76.821% when pulling f398ce5 on ADReece:fix-mixed-content-load-balancer into 7a12e15 on DarkaOnLine:master.

@DarkaOnLine DarkaOnLine merged commit a91f7aa into DarkaOnLine:master May 9, 2023
@ADReece ADReece deleted the fix-mixed-content-load-balancer branch May 9, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkaOnLine DarkaOnLine DarkaOnLine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app('request')->secure() Causes Mixed-Content errors behind a Load Balancer.
3 participants
@ADReece @coveralls @DarkaOnLine