fix: plaques would crash when interacting with no data provided #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadebenn
approved these changes
Mar 2, 2024
|
Lgtm |
Jettford
approved these changes
Mar 4, 2024
EmosewaMC
approved these changes
Mar 4, 2024
aronwk-aaron
deleted the
vanity-docs-and-prevent-plaques-from-crashing-when-no-data-is-given
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also docs
tested that normal plaques work
tested that ones
/spawn'd in don't crash when interacting anymoretested that DLU vanity plaques work
Feel free to give feedback and criticism on the docs as I wasn't exactly sure what all to write, but hopefully that covers most use cases and we can adapt as user have questions or confusion.