chore: Set default symbol visibility to hidden in CMAKE #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before change: After change: |
|
Will want to get the offer cmake PR I think. To avoid more merge conflict. But looks good otherwise |
EmosewaMC
reviewed
Mar 4, 2024
|
Looks like it can still automerge. Kind of surprised, really. |
aronwk-aaron
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default C++ symbol visibility to hidden, since we aren't exporting any of them at all. This shrinks WorldServer by about 0.8 MB without any impact to functionality. Tested by moving around Gnarled Forest for about 30 minutes, completing side missions.