-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor slash commands system into more scalable system #1510
Conversation
Note to self: fix failing test |
idk how these werent failing before. Seems to have been magic.
Thanks emo |
make help command useful fix mac error TODO: remove the multiple not founds/ rework the structure to split into help and handling
OKAY, this is the final form of this PR, I need to check some things with the help command not displaying correctly in-game that may be due to some char limit of that message, but that's a tangent. |
Declining to review since I contributed to the pr and am biased. I will keep cleaning it up and helping work on it though |
pass through added code for optimizations and cleanup as well as reduce the amount of scoping for readability and maintainability
text prints correctly and utilizes the asterisk found in reverse engineering. Its used for denoting where a localized string starts and ends. Edit: I see the weirdness... not sure why its repeating the last chunk of text for large strings |
afaict, we are sending the correct data, however whats being printed is not correct. Will have to debug further to figure out the issue. |
gmlevel 0, 9, 7, 9, 0 sets my gm level to the correct value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finished a code passthrough. Don't see anything missed on my end, but will not be explicitly approving as I contributed to the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finished a code passthrough. Don't see anything missed on my end, but will not be explicitly approving as I contributed to the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
props for actually undertaking this :')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny note, completely non-blocking (presuming it isn't a dumb comment to begin with). Awesome stuff other than that.
Spot checked a several of the commands.
Things still work and there is a new help command.
A bulk of the changes are breaking up the big if-else-if block into functions and registering each command.
Future PR will break out each set of command into it's own file. (dev, gm zero, and gm greater than zero command)