feat: Client commands stubbing #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding list of client commands provided to me by EmosewaMC
EmosewaMC
approved these changes
May 22, 2024
|
as a note for the testing, these commands have always worked and were never broken. This just prevents a "command not found" from being sent to the clients when one of these is used, and adds a help message for them. |
aronwk-aaron
approved these changes
May 22, 2024
aronwk-aaron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEAT: Implementing client commands
Description: Implemented a list of commands which are used by the client rather than the server. Essentially made an empty command for the server which parses the command through to the client, which then does its thing (this mostly includes things like emotes and a few config options)
Motivation and Context: Adding the ability to use these commands to continue fleshing out our current command palette and help command.
Type of Changes: Changes made to SlashCommandHandler.cpp to include additional command attributes for client commands, added a declaration in GMZeroCommands.h and definition in GMZeroCommands.cpp
How Has This Been Tested: Running commands in game, which triggers their respective emotes and or other functionality. Additionally, these client commands are listed in the
/helpmenu for users to have access to them and get information as necessary.