Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate AgSpaceStuff and AgShipShake #83

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

red031000
Copy link
Contributor

This should fix the below error on server startup

[07-12-21 04:58:49] [CppScripts]: Attempted to load CppScript for 'scripts\ai\AG\L_AG_SHIP_SHAKE.lua', but returned InvalidScript.

I have tested myself in game on a new character and verified that the desired functionality is present
The elimination of the error should also help people asking for help (and those providing help) in setting up the server, as they do not go looking for issues in potentially the wrong place (also it's an elimination of an error, which is always nice)

I've also fixed a cmake warning in the PR

@codeshaunted codeshaunted added the enhancement New feature or request label Dec 7, 2021
Copy link
Contributor

@MickVermeulen MickVermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, next time try to separate commits into concrete sections, e.g. when just looking at the message "separate AgSpaceStuff and AgShipShake" it's not clear that it also changes the CMakeFile. Non blocking tho, just something to keep in mind going forward to keep the commit history clean.

@red031000 red031000 force-pushed the main branch 2 times, most recently from 9811a15 to c240418 Compare December 7, 2021 20:48
@MickVermeulen
Copy link
Contributor

Tested, works great. Thanks for the contribution!

@MickVermeulen MickVermeulen merged commit 5281253 into DarkflameUniverse:main Dec 7, 2021
@MickVermeulen
Copy link
Contributor

MickVermeulen commented Dec 8, 2021

Wanted to comment on this: please make sure that your commits and your PRs semantically match what you're contributing. I now approved the commit and was just waiting to test it after which core functionality in Entity.cpp was edited which was not at all reflected in the PR name. If you want to work on multiple things locally you can create local branches using git checkout -b <branch-name> and create pull requests for each of them separately, this makes it way easier for us to review the contributions you make.

@red031000 red031000 mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants