Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for zero values and decoratingValues on the funnel #5

Merged
merged 5 commits into from
Aug 20, 2022
Merged

Add support for zero values and decoratingValues on the funnel #5

merged 5 commits into from
Aug 20, 2022

Conversation

aussiDavid
Copy link
Contributor

  1. Show rows when the value is zero or higher
  2. Allow the client to specify how to render the value in the row

The package can now be updated to version 0.2.0

@davidfrisch
Copy link

Please add these features ! 👍

DarylBuckle
DarylBuckle approved these changes Aug 20, 2022
View reviewed changes
Copy link
Owner

@DarylBuckle DarylBuckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this PR @aussiDavid

@DarylBuckle DarylBuckle merged commit b33be1c into DarylBuckle:master Aug 20, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarylBuckle DarylBuckle DarylBuckle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aussiDavid @davidfrisch @DarylBuckle @bry221996 @thalisferrari