Add a fragment request timeout #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsilhavy
reviewed
Oct 7, 2020
dsilhavy
reviewed
Oct 7, 2020
|
Does it raise an error when the request fails due to timeout? |
robertbryer
force-pushed
the
fragmentRequestTimeout
branch
from
ebd003c
to
6e9c98e
Compare
|
@bbert It calls the onloadend handler, so it's treated as if it failed normally, like a non-200 code, including the retries. There's no specific error to indicate that it failed because of a timeout. |
|
Cheers for the review @dsilhavy, I fixed the issues and rebased it just now. |
OK great, I tried, that works fine. Thanks for this PR |
bbert
pushed a commit
to Orange-OpenSource/dash.js
that referenced
this pull request
Nov 4, 2020
* Created test for fragment request timeout set * Exposed setting fragment timeouts on media player interface * Added logging to report HTTPLoader ontimeout callback * Update to use settings instead of functions on MediaPlayer * Add fragmentRequestTimeout JSDoc and type definition, and default to 0 when NaN. Co-authored-by: magnuswoody <magnus.woodgate@bbc.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the setting fragmentRequestTimeout for making fragment requests fail after the timeout.