Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease already seen initData log from warn to info #3456

Merged

Conversation

gesinger
Copy link
Contributor

I wanted to put up this PR to potentially start a discussion, or, if it's deemed appropriate, to get it merged.

For many encrypted streams, it's not uncommon to see the same initData appear repeatedly. This is especially true for live streams. In running some streams, we end up getting tons of warning logs due to this message.

Since there's no action to be taken, as this is a valid case, I was thinking that it should be at a lower log level than warn, which is generally used for more actionable issues.

Let me know what you think, and thank you.

@dsilhavy
Copy link
Collaborator

Completely agree on this one. Before I can merge:

Following our contribution guidelines, and given this is your first PR, could you please send me a signed copy of dash.js feedback agreement?

@dsilhavy dsilhavy added this to the 3.2.0 milestone Nov 17, 2020
@dsilhavy dsilhavy self-requested a review November 17, 2020 17:41
@dsilhavy dsilhavy merged commit 8dd37d4 into Dash-Industry-Forum:development Nov 17, 2020
@gesinger
Copy link
Contributor Author

Thank you @dsilhavy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants