Feature functional tests audio switching

[vrosenberg]

No description provided.

[bbert]

@vrosenberg please find my code review in commit 602b7c4 on branch https://github.com/Dash-Industry-Forum/dash.js/tree/fraunhoferfokus-feature-functionalTestsAudioSwitching

If you agree with that you could proceed the same way for text tracks switching

[vrosenberg]

@bbert
The play progress check doesn't seem to work
Often ending in an assertion error, where false was to be expected true
I tested without this part of the code:

utils.log(NAME, 'Check if playing');
const progressing = await command.executeAsync(player.isProgressing, [constants.PROGRESS_DELAY, constants.EVENT_TIMEOUT]);
assert.isTrue(progressing);

and the audio switch case seems to function.

An example stream where the progress check failed would be:
https://media.axprod.net/TestVectors/v7-Clear/Manifest_1080p.mpd

Do you have an idea what the problem might be?

I will proceed the same for text track switching

[bbert]

@vrosenberg there is indeed an issue, let me explain you:

• when getting the tracks through the Leadfoot command, undefined object properties are transformed to null values
• when setting new track, if new track is the same but if any property (such as 'id' for example) is undefined, then a null value will be compared to an undefined value in MediaController.isTracksEqual(), and tracks will be considered as being different
• as a consequence, that leads to inconsistencies in the player which fails to play after track switch

I am trying to find a solution and will let you lnow

[bbert]

@vrosenberg Please check branch https://github.com/Dash-Industry-Forum/dash.js/tree/fraunhoferfokus-feature-functionalTestsAudioSwitching, I've updated so that we do not switch on initial track to get around issue I described

@dsilhavy shouldn't MediaPlayer API return only objects/values that can serialized to JSON to avoid issues with undefined property values?

[vrosenberg]

Thank you @bbert
I will implement that solution for text switching (#3465).
Would the same workaround function with initial text (#3500) and initial audio (#3499)?

[bbert]

No you don't need since you simply set the default language for these tests

[vrosenberg]

@bbert
I merged your changes from your branch.
Please check it out.
If there is nothing more to add to this PR we will merge it.

[bbert]

@vrosenberg that sounds good, thx