Fix setting MediaSource's duration #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbert
added a commit
to Orange-OpenSource/dash.js
that referenced
this pull request
Mar 4, 2021
* Check if no SourceBuffer is updating when setting MediaSource duration * Check if no SourceBuffer is updating when setting MediaSource duration * fix MediaSourceController unit tests
jlks
pushed a commit
to bbc/dash.js
that referenced
this pull request
Jun 21, 2021
* Check if no SourceBuffer is updating when setting MediaSource duration * Check if no SourceBuffer is updating when setting MediaSource duration * fix MediaSourceController unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting duration on MediaSource, if any SourceBuffer is updating it throws an
InvalidStateErrorexception:Uncaught DOMException: Failed to set the 'duration' property on 'MediaSource': The 'updating' attribute is true on one or more of this MediaSource's SourceBuffersThis PR fixes this issue by check if no SourceBuffer is updating when setting MediaSource duration