Updated _applyServiceDescription(): only enable LL on critical SupplementalProperty, correct min/maxDrift #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only enable Low latency on presence of "urn:dvb:dash:lowlatency:critical:2019" SupplementalProperty (according to DVB DASH spec S10.20.5) - On presence of Service Description set the low latency parameters in `settings` - Correct setting of `maxDrift`, and `minDrift` according to DVB DASH spec (S10.20.6)
|
@piersoh Thanks this looks good. Can you please merge the latest changes from development, then I can merge your PR. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code only makes any settings updates from ServiceDescription on presence of critical SupplementalProperty so this PR corrects the behaviour according to the DVB DASH spec:
urn:dvb:dash:lowlatency:critical:2019SupplementalProperty (according to DVB DASH spec S10.20.5 - It is also mentioned in the spec that LL can be enabled due to two other conditions in the spec so these could also be added at a later date)settingsmaxDrift, andminDriftaccording to DVB DASH spec (S10.20.6)