throughput calculation in FetchLoader #3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
makcay
commented
Jun 10, 2021
makcay
commented
- moof parsing logic had to ignore some bytes, so instead of returning bytes and time seperately. FetchLoader calculates the throughput as stated in LoL+ paper and sends that data directly.
- in ThroughputHistory that direct calculated throughput calculated value is used if it is present. Otherwise traditional throughput calculation s used.
Open
5 tasks
mlasak
added a commit
to fraunhoferfokus/dash.js
that referenced
this pull request
Jun 15, 2021
dsilhavy
added a commit
that referenced
this pull request
Jun 15, 2021
…tion in LL CTE streaming (#3660) * Prepare new throughput calculation method Adds as well new kind of tests, unit tests in browser env with karma * finalize new tp calc method still todo: - tests - finalize artificial delay approach * Add option to reference player to be able to select new tp calc method * Set sheduling delay to a minimum also removing some irrelevant log outputs * Changes after review comments and added better buffer stability detection * fix unit test * refactor buffer stability detection clean up, refactoring, renaming * add sample page for ll streaming with AAST based tp calculation * small ui text correction * Add missing browser unit tests * UpdateCurrentTime should seek back to the live edge for low latency streams once we fall out of the DVR window * For low latency streams InsufficientBufferRule.js should not be ignored after a seek * Fix unit tests for InsufficientBufferRule * Reflect changes introduced in #3663 * Fix formatting in aast_tp_calc.html Co-authored-by: dsilhavy <daniel.silhavy@fokus.fraunhofer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.