Treat HTTP headers case-insensitively #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l1bbcsg
changed the title
|
@l1bbcsg Thank you for your contribution. Following our contribution guidelines, and since this seems to be your first PR, could you please send me a signed copy of dash.js feedback agreement? Thanks |
|
@l1bbcsg Is it possible for you to sign this? |
|
Just did it actually. Sorry for the delay, ran it through legal department of my company first, then it took some time to find a printer I could use in the COVID world. @dsilhavy Can you clarify where to send it? Theres a mailing list, but I can't find its actual email and you don't have a public email on your profile. |
|
@l1bbcsg Thanks, please send to daniel.silhavy (at) fokus.fraunhofer.de |
|
Done |
|
Thanks this PR looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP headers are case-insensitive and
Headersobject keys are lowercase to accommodate for that.getLatestMPDRequestHeaderValueByIDis used only once within the project and it's called with a string'Date'which without being converted to lower case never matches any headers. This caused time synchronisation throughDateheader not to work.