New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EventController._triggerRemainingEvents not doing anything #3725

Merged

dsilhavy merged 1 commit into Dash-Industry-Forum:development from l1bbcsg:development

Aug 4, 2021

Contributor

l1bbcsg commented Aug 4, 2021

EventController apparently was meant to trigger pending events on stop, but this was not happening because of what seems like a silly typo.

This in fact raised an exception which was consumed by an empty catch clause. This also does not seem intentional.


          Fix _triggerRemainingEvents not doing anything

da770b0

dsilhavy added this to the 4.1.0 milestone

Collaborator

dsilhavy commented Aug 4, 2021

Thanks!

dsilhavy merged commit 33c4326 into Dash-Industry-Forum:development

dsilhavy self-requested a review

August 4, 2021 13:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet