Fix PlaybackErrorEvent error TS typing #4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PlaybackErrorEvent` when triggered in `PlaybackController`, attaches the original `MediaError` as `error` property. This commit corrects the TS typing to reflect that.
kris-youview
force-pushed
the
kris/playback-error-event-fix
branch
from
253a04d
to
a1c033a
Compare
|
Updated the unit test for this. |
eirikbjornr
pushed a commit
to bbc/dash.js
that referenced
this pull request
Feb 14, 2024
`PlaybackErrorEvent` when triggered in `PlaybackController`, attaches the original `MediaError` as `error` property. This commit corrects the TS typing to reflect that.
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlaybackErrorEventwhen triggered inPlaybackController, attaches the originalMediaErroraserrorproperty. This commit corrects the TS typing to reflect that.Context
See here for reference: https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/controllers/PlaybackController.js#L714
We've encountered this as we pass errors using
MessageBusand we failed to serialise this one as it carries anobjectproperty (thus becomes anobjectitself) which was not correctly reflected inPlaybackErrorEventTS type.Also see here: https://html.spec.whatwg.org/multipage/media.html#dom-media-error