DasharoSystemFeaturesUiLib: Use callbacks to update CPU Throttling Threshold

[miczyg1]

For some reason the CPU Throttling Threshold dsiplayed negative value when user changed CPU throttling, exited Power Management Options menu, went back to front page and then entered Power Management Options menu again.

Always calculate the threshold based on PCD and current throttling offset value. Add interactive flag to the options and patch the value in the callback.

[krystian-hebel]

Check if UEFI revocation list is up-to-date / check (pull_request) Failing after 7s

Is it because of CVE-2024-7344?

[mkopec]

@krystian-hebel looks like it's because of CVE-2023-24932

[SergiiDmytruk]

For some reason the CPU Throttling Threshold dsiplayed negative value when user changed CPU throttling, exited Power Management Options menu, went back to front page and then entered Power Management Options menu again.

This is worrisome, like there is a memory issue that will now affect something else since a field has been removed (e.g., HybridCpuArchitecture which is the next one). Or is this an issue with how forms are implemented (now necessarily in our code)? Were you able to reproduce it on QEMU? It didn't work for me on v0.2 with all the menus.

[miczyg1]

For some reason the CPU Throttling Threshold dsiplayed negative value when user changed CPU throttling, exited Power Management Options menu, went back to front page and then entered Power Management Options menu again.

This is worrisome, like there is a memory issue that will now affect something else since a field has been removed (e.g., HybridCpuArchitecture which is the next one). Or is this an issue with how forms are implemented (now necessarily in our code)? Were you able to reproduce it on QEMU? It didn't work for me on v0.2 with all the menus.

I think it has to do with how read directive in VFR/IFR works and when it is invoked, rather than memory issue.

[SergiiDmytruk]

OVMF seems to work the same with and without these changes (variables are updated correctly), so seems like they at least don't break anything.