fix: handle attempt to send response when port is disconnected #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-coruble
approved these changes
Feb 26, 2024
fellowseb
force-pushed
the
fix/web-platform-948-attempting-to-use-disconnected-port
branch
2 times, most recently
from
a302c2c to
956ab05
Compare
a-coruble
approved these changes
Feb 27, 2024
|
Can merge after #58 |
fellowseb
force-pushed
the
fix/web-platform-948-attempting-to-use-disconnected-port
branch
from
956ab05 to
3e0873f
Compare
fellowseb
deleted the
fix/web-platform-948-attempting-to-use-disconnected-port
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the "autoReconnect" feature by handling the response in case the channel went down (Disconnected) after receiving a message: if the channel has the autoReconnect capability we try to apply it. In any case if after trying the autoReconnect the channel is still Disconnected, we don't try to send the response.
I also added a hacky
flushPromisestesting utility that allows running all internal promises.