Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Change name in derived type for obs and sim response #84

Merged
merged 2 commits into from
Sep 15, 2023
Merged

MAINT: Change name in derived type for obs and sim response #84

merged 2 commits into from
Sep 15, 2023

Conversation

inoelloc
Copy link
Contributor

  • Create 2 new derived types: Response_DataDT and U_Response_DataDT
  • Rename in Input_DataDT obs_response -> response_data
  • Rename in OutputDT sim_response -> response
  • Add some comments in derived type files header
  • Apply rename to all files including Python ones

@inoelloc
MAINT: Change name in derived type for obs and sim response
2e1832e 
- Create 2 new derived types: Response_DataDT and U_Response_DataDT
- Rename in Input_DataDT obs_response -> response_data
- Rename in OutputDT sim_response -> response
- Add some comments in derived type files header
- Apply rename to all files including Python ones
@inoelloc inoelloc added the maintenance Maintenance label Sep 15, 2023
nghi-truyen
nghi-truyen approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@nghi-truyen nghi-truyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai regénéré l'adjoint. Je te laisse merger si c'est ok

@inoelloc
Copy link
Contributor Author

J'ai regénéré l'adjoint. Je te laisse merger si c'est ok

Thanks !

@inoelloc inoelloc merged commit 2559ff8 into maintenance/1.0.x Sep 15, 2023
18 checks passed
@inoelloc inoelloc deleted the enc-bayesian branch September 21, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghi-truyen nghi-truyen nghi-truyen approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inoelloc @nghi-truyen