This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
feature: Make deployment replicas configurable on resource level #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loyment spec refs: #112
health and metrics now make their endpoint calls to the first replica refs: #112
queries default to first replica
and change replica call to queryparam instead of pathparam
…replica amount refs: #112
now relying on Kubernetes client error handling and mapping to a new exception refs: #112
|
The changes of this PR are documentated in a gitbook PR |
flippingbits
suggested changes
Mar 13, 2023
platform-api/src/main/java/io/datacater/core/deployment/DeploymentEndpoint.java
Outdated
Show resolved
Hide resolved
platform-api/src/main/java/io/datacater/core/deployment/K8Deployment.java
Outdated
Show resolved
Hide resolved
platform-api/src/main/java/io/datacater/core/deployment/K8Deployment.java
Outdated
Show resolved
Hide resolved
reomved some failing tests since they can't be tested locally anymore. We need to implement integration tests for underlying kubernetes tests refs: #112
|
This PR is ready for review @flippingbits @HknLof @olis1996 I had to remove two tests regarding the logs, since the kubernetes mockserver doesn't actually seem to create real deployments/replicas under the hood. I have created an issue #193 to address this. |
platform-api/src/main/java/io/datacater/core/deployment/StaticConfig.java
Outdated
Show resolved
Hide resolved
….com/DataCater/datacater into feat/rework-deployment-configuration
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to make the deployment replica amount configurable at the resource level, when creating a new deployment.
Ticket reference: #112