Rename statsByStatusCode to statsByErrorCode
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyarb
reviewed
Jun 20, 2024
| @@ -1589,7 +1589,7 @@ message KafkaAggregation { | |||
| KafkaRequestHeader header = 1; | |||
| string topic = 2; | |||
| // The range of Kafka error codes spans from -1 to 119. | |||
| map<int32, KafkaStats> statsByStatusCode = 4; | |||
| map<int32, KafkaStats> statsByErrorCode = 4; | |||
There was a problem hiding this comment.
It more clearly communicates that we are mapping error codes to the stats, which might not be immediately obvious to the average reader
guyarb
approved these changes
Jun 20, 2024
mx-psi
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Jun 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/DataDog/agent-payload/v5](https://github.com/DataDog/agent-payload) | `v5.0.122` -> `v5.0.123` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>DataDog/agent-payload (github.com/DataDog/agent-payload/v5)</summary> ### [`v5.0.123`](https://github.com/DataDog/agent-payload/releases/tag/v5.0.123) [Compare Source](https://github.com/DataDog/agent-payload/compare/v5.0.122...v5.0.123) #### What's Changed - Rename `statsByStatusCode` to statsByErrorCode by [@​DanielLavie](https://github.com/DanielLavie) in [https://github.com/DataDog/agent-payload/pull/320](https://github.com/DataDog/agent-payload/pull/320) **Full Changelog**: DataDog/agent-payload@v5.0.122...v5.0.123 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Renames the
statsByStatusCodefield inKafkaAggregationtostatsByErrorCode. Renaming a proto field doesn't break the wire protocol, so backward compatibility is not a concern in this case.