Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPM-3357] Add field for local and remote ECS task #338

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

hmahmood
Copy link
Contributor

@hmahmood hmahmood commented Aug 30, 2024

What does this PR do?

Adds fields for local and remote ECS tasks to the Connection and CollectorConnections messages.

Dependent PRs:
https://github.com/DataDog/dd-go/pull/148776
https://github.com/DataDog/dd-go/pull/149703

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

Reviewers: please see the review guidelines.

@hmahmood hmahmood force-pushed the hasan.mahmood/add-ecs-tasks branch from 9dfd628 to 6f4bb90 Compare August 30, 2024 15:20
@hmahmood hmahmood force-pushed the hasan.mahmood/add-ecs-tasks branch from 6f4bb90 to bdc4004 Compare September 3, 2024 22:30
@hmahmood hmahmood changed the title Add field for local and remote ECS task [NPM-3357] Add field for local and remote ECS task Sep 11, 2024
@hmahmood hmahmood marked this pull request as ready for review September 11, 2024 17:12
@hmahmood hmahmood requested review from a team as code owners September 11, 2024 17:12
Copy link
Contributor

@wiyu wiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from #processes

Copy link

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ASC owned files

@hmahmood hmahmood merged commit 234c626 into master Sep 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants