Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protobuf] remove legacy protobuf compiler #347

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

leeavital
Copy link
Contributor

As described in #337 we used to use two different protobuf compilers in this repo.

Now we only use one, so we can get rid of references to the old one.

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

Reviewers: please see the review guidelines.

@leeavital leeavital requested a review from a team as a code owner September 25, 2024 21:08
As described in #337 we used to use two different protobuf compilers in this repo.

Now we only use one, so we can get rid of references to the old one.
@leeavital leeavital force-pushed the lee.avital/legacy_proto_no_more branch from 00abc0d to 6b35fef Compare October 1, 2024 17:22
@leeavital leeavital requested review from a team as code owners October 1, 2024 17:22
@leeavital leeavital changed the base branch from lee.avital/java_codegen to master October 1, 2024 17:22
@leeavital
Copy link
Contributor Author

/merge -m squash

@dd-devflow
Copy link

dd-devflow bot commented Oct 1, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in master is 2m.

Use /merge -c to cancel this operation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants