🐛 [RUMF-1267] remove last circular dependencies #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reorganize recorder types moving most of the src/domain/record/types in src/types. I wanted to do this for a long time, because I'm always confused when looking for a specific type of the recorder. Now everything is at the same level.
* It is a bit unusual to have *Param types. Those suffixes have been removed * MouseInteractions and MediaInteractions enums have been renamed to MouseInteractionType and MediaInteractionType to be a bit more conventional. * ViewportResizeDimention have been renamed to ViewportResizeDimension
BenoitZugmeyer
force-pushed
the
benoit/remove-circular-dependencies-3
branch
from
7cd426d
to
2b97076
Compare
Codecov Report
@@ Coverage Diff @@
## main #1577 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 119 119
Lines 4468 4469 +1
Branches 1001 1001
=======================================
+ Hits 4055 4056 +1
Misses 413 413
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
| @@ -0,0 +1,236 @@ | |||
| import type { TimeStamp } from '@datadog/browser-core' | |||
There was a problem hiding this comment.
I like the split of the types but now that I'm looking at it, it feels a bit weird to have domain/record/types.ts and /types/record.ts.
Either we collocate the types to the module or use a types folder. My personal preference is to collocate the type with the module but it's not a strong opinion.
Wdyt
There was a problem hiding this comment.
Agreed, let's collocate types to the module where they are used
BenoitZugmeyer
force-pushed
the
benoit/remove-circular-dependencies-3
branch
from
bf2085f
to
6e6ac03
Compare
amortemousque
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following #1559 and #1567, this PR removes some more circular dependencies, as well as taking the opportunity to clean recorder types a bit.
Those two last depency loops did not have been caught because of an issue with
import/no-cyclerule. They have been caught by importing the RUM SDK into a small rollup project.
Changes
Testing
I have gone over the contributing documentation.