Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨[RUM] add view resource count #189

Merged
merged 4 commits into from
Dec 4, 2019
Merged

✨[RUM] add view resource count #189

merged 4 commits into from
Dec 4, 2019

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Dec 3, 2019

Trigger a new rumResource life cycle event when a RumResourceEvent is added on the batch

@bcaudan bcaudan requested a review from a team as a code owner December 3, 2019 16:55
BenoitZugmeyer
BenoitZugmeyer requested changes Dec 3, 2019
View reviewed changes
packages/rum/src/lifeCycle.ts Outdated Show resolved Hide resolved
@bcaudan
✅[e2e] add missing expectation
01aa64a
@bcaudan
✅[e2e cbt] fix wrong expectation
ec56d6a 
on safari, there is a resource event for the current page
@bcaudan bcaudan merged commit 63a3a83 into master Dec 4, 2019
@bcaudan bcaudan deleted the bcaudan/rum-resources branch December 4, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorieux glorieux glorieux left review comments

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcaudan @BenoitZugmeyer @glorieux