Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[internal monitoring] add RUM/Logs context #249

Merged
merged 4 commits into from
Feb 4, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 4, 2020

It would allow us to identified more precisely in which context an issue occurred (org id, session id, ...)

@bcaudan bcaudan requested a review from a team as a code owner February 4, 2020 11:01
when app is compiled with webpack, logs and rum use the same core lib which provoked a max call stack size issue on console.error usage
@bcaudan bcaudan force-pushed the bcaudan/internal-monitoring-context branch from cf49b08 to b00054d Compare February 4, 2020 12:57
@codecov-io
Copy link

Codecov Report

Merging #249 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   86.08%   86.12%   +0.03%     
==========================================
  Files          24       24              
  Lines        1294     1297       +3     
  Branches      271      271              
==========================================
+ Hits         1114     1117       +3     
  Misses        180      180
Impacted Files Coverage Δ
packages/rum/src/viewTracker.ts 94.52% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00054d...9a86ca3. Read the comment docs.

Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@bcaudan bcaudan merged commit cd4a277 into master Feb 4, 2020
@bcaudan bcaudan deleted the bcaudan/internal-monitoring-context branch February 4, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants