Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-71] do not report negative performance timing duration #264

Merged
merged 3 commits into from
Feb 12, 2020

Conversation

BenoitZugmeyer
Copy link
Member

No description provided.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner February 12, 2020 11:31
@codecov-io
Copy link

codecov-io commented Feb 12, 2020

Codecov Report

Merging #264 into master will increase coverage by 0.82%.
The diff coverage is 88.23%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #264      +/-   ##
========================================
+ Coverage   85.18%    86%   +0.82%     
========================================
  Files          24     24              
  Lines        1323   1322       -1     
  Branches      276    279       +3     
========================================
+ Hits         1127   1137      +10     
+ Misses        196    185      -11
Impacted Files Coverage Δ
packages/rum/src/resourceUtils.ts 96.07% <88.23%> (+5.69%) ⬆️
packages/rum/src/rum.entry.ts 71.42% <0%> (+2.04%) ⬆️
packages/core/src/requestCollection.ts 96.15% <0%> (+13.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e2a99d...3cddcdd. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit 33178dc into master Feb 12, 2020
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/fix-negative-durations branch February 12, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants