Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 [RUM-3709] Fix local build #2670

Merged
merged 1 commit into from
Mar 25, 2024
Merged

👷 [RUM-3709] Fix local build #2670

merged 1 commit into from
Mar 25, 2024

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Mar 25, 2024

Motivation

Local build is failing with error:

@datadog/browser-rum-core: ../core/cjs/domain/error/trackRuntimeError.d.ts(9,32): 
    error TS2694: Namespace '"packages/rum-core/src/index"' has no exported member 'noop'.

Changes

This behaviour has been introduced with the update of typescript from 5.3.3 to 5.4.3, so reverting to last working version while investigating.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner March 25, 2024 18:35
@bcaudan bcaudan merged commit 163c54c into main Mar 25, 2024
16 of 17 checks passed
@bcaudan bcaudan deleted the bcaudan/fix-local-build branch March 25, 2024 18:48
@bcaudan
Copy link
Contributor Author

bcaudan commented Mar 27, 2024

After further investigation, it seems to be related to this issue microsoft/TypeScript#57956.

Evidences:

@bcaudan bcaudan mentioned this pull request Mar 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants