Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUMF-264] add compatibility with server side rendering #273

Merged
merged 5 commits into from
Feb 17, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 14, 2020

In loading code, retrieve global object depending on the environment instead of window.

Automate check by executing test app source code.

fixes #235

@bcaudan bcaudan requested a review from a team as a code owner February 14, 2020 15:54
packages/core/src/utils.ts Outdated Show resolved Hide resolved
packages/core/src/utils.ts Outdated Show resolved Hide resolved
test/app/app.ts Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #273 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   86.29%   86.25%   -0.04%     
==========================================
  Files          24       24              
  Lines        1313     1310       -3     
  Branches      278      278              
==========================================
- Hits         1133     1130       -3     
  Misses        180      180
Impacted Files Coverage Δ
packages/core/src/utils.ts 97.87% <100%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9830d6...a2b9989. Read the comment docs.

@bcaudan bcaudan merged commit 282de4c into master Feb 17, 2020
@bcaudan bcaudan deleted the bcaudan/ssr branch February 17, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safely access window or wait until after calling .init
3 participants