Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[RUMF-266] fix xhr incorrect status reported on late abortion #283

Merged
merged 4 commits into from
Feb 28, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 27, 2020

An xhr request can be aborted after completion, overriding its original status by an aborted one (ie. statusCode: 0).
Use onreadystatechange in order to retrieve xhr status as soon as possible.

Convert existing xhr e2e tests to unit tests.

closes #257

@bcaudan bcaudan requested a review from a team as a code owner February 27, 2020 16:18
@bcaudan bcaudan merged commit 4867a87 into master Feb 28, 2020
@bcaudan bcaudan deleted the bcaudan/fix-angular-xhr-abort branch February 28, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants