Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Update typescript-eslint monorepo to v8 (major) - abandoned #2921

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,12 @@ module.exports = {
'ts-check': 'allow-with-description',
},
],
'@typescript-eslint/ban-types': [
'@typescript-eslint/no-restricted-types': [
'error',
{
types: {
/* eslint-disable id-denylist */
Object: { message: 'Avoid using the `Object` type. Did you mean `object`?' },
object: false,
Function: { message: 'Avoid using the `Function` type. Prefer a specific function type, like `() => void`.' },
Boolean: { message: 'Avoid using the `Boolean` type. Did you mean `boolean`?' },
Number: { message: 'Avoid using the `Number` type. Did you mean `number`?' },
Expand Down
4 changes: 3 additions & 1 deletion developer-extension/src/panel/components/panel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ export function Panel() {
const [activeTab, setActiveTab] = useState<string | null>(DEFAULT_PANEL_TAB)
function updateActiveTab(activeTab: string | null) {
setActiveTab(activeTab)
activeTab && datadogRum.startView(activeTab)
if (activeTab) {
datadogRum.startView(activeTab)
}
}

return (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,9 @@ function Entry({
}

const handleClearClick = () => {
onChange && onChange(null)
if (onChange) {
onChange(null)
}
reloadPage()
}

Expand Down
1 change: 1 addition & 0 deletions developer-extension/src/panel/hooks/useSettings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export function useSettings() {
// If we don't have settings yet, it means that we are still loading them from the storage. Throw
// the promise so it'll be caught by the Suspense boundary.
if (!settings) {
// eslint-disable-next-line @typescript-eslint/only-throw-error
throw storageLoadingPromise
}

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@
"@types/cors": "2.8.17",
"@types/express": "4.17.21",
"@types/jasmine": "3.10.18",
"@typescript-eslint/eslint-plugin": "7.18.0",
"@typescript-eslint/parser": "7.18.0",
"@typescript-eslint/eslint-plugin": "8.0.1",
"@typescript-eslint/parser": "8.0.1",
"@wdio/browserstack-service": "8.40.5",
"@wdio/cli": "8.40.5",
"@wdio/jasmine-framework": "8.40.5",
Expand Down
Loading